> On Feb. 19, 2014, 5:09 p.m., Dominic Hamon wrote: > > src/tests/log_tests.cpp, line 147 > > <https://reviews.apache.org/r/18261/diff/2/?file=497489#file497489line147> > > > > Consider setting all these constants as named constants. Ie, > > kTruncatePosition, kEndAppendPosition, etc. > >
We usually don't do that in test because everything is local. If we define each number we use in test as a constant, that will be too much :) > On Feb. 19, 2014, 5:09 p.m., Dominic Hamon wrote: > > src/tests/log_tests.cpp, line 263 > > <https://reviews.apache.org/r/18261/diff/2/?file=497489#file497489line263> > > > > Consider adding a benchmark to measure the time taken for this, and > > maybe to check for regressions. Measure and check the time taken. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18261/#review34872 ----------------------------------------------------------- On Feb. 19, 2014, 6:03 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18261/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 6:03 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1014 > https://issues.apache.org/jira/browse/MESOS-1014 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 768c66a > src/log/leveldb.cpp 7819963 > src/tests/log_tests.cpp 7e6dbde > > Diff: https://reviews.apache.org/r/18261/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
