----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/#review36120 -----------------------------------------------------------
src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment67031> this should be __AUTHORIZER_AUTHORIZER_HPP__ src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment67032> if you have a static factory create method, do you also need a public default constructor? src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment67036> consider returning a Try<Owned<Authorizer> > to indicate passing of ownership of memory. src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment67033> this should be marked explicit to avoid unwanted implicit conversion. src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment67034> consider 'Owned' to indicate ownership of this memory. Eventually, this would be unique_ptr. src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment67035> explicit src/tests/authorization_tests.cpp <https://reviews.apache.org/r/18730/#comment67037> also test invalid user - Dominic Hamon On March 3, 2014, 11:09 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18730/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 11:09 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-911 > https://issues.apache.org/jira/browse/MESOS-911 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4 > src/authorizer/authorizer.hpp PRE-CREATION > src/tests/authorization_tests.cpp PRE-CREATION > src/tests/master_contender_detector_tests.cpp > 8da7420e18c7a960b566fae13a5975857eb777ee > > Diff: https://reviews.apache.org/r/18730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
