> On March 4, 2014, 5:44 p.m., Dominic Hamon wrote: > > src/authorizer/authorizer.hpp, line 68 > > <https://reviews.apache.org/r/18730/diff/2/?file=509429#file509429line68> > > > > this should be marked explicit to avoid unwanted implicit conversion.
We havent' followed this convention in the code base unless specifically needed. For consistency, I'll drop this. > On March 4, 2014, 5:44 p.m., Dominic Hamon wrote: > > src/authorizer/authorizer.hpp, line 77 > > <https://reviews.apache.org/r/18730/diff/2/?file=509429#file509429line77> > > > > consider 'Owned' to indicate ownership of this memory. Eventually, this > > would be unique_ptr. This is a private variable. So ownership is controlled by the class. > On March 4, 2014, 5:44 p.m., Dominic Hamon wrote: > > src/authorizer/authorizer.hpp, line 84 > > <https://reviews.apache.org/r/18730/diff/2/?file=509429#file509429line84> > > > > explicit see above. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/#review36120 ----------------------------------------------------------- On March 4, 2014, 7:09 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18730/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 7:09 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-911 > https://issues.apache.org/jira/browse/MESOS-911 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4 > src/authorizer/authorizer.hpp PRE-CREATION > src/tests/authorization_tests.cpp PRE-CREATION > src/tests/master_contender_detector_tests.cpp > 8da7420e18c7a960b566fae13a5975857eb777ee > > Diff: https://reviews.apache.org/r/18730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
