> On March 10, 2014, 3:10 p.m., Timothy St. Clair wrote: > > So IMHO, --without-XYZ will become an onerous pattern to follow when > > building all of Mesos against system dependencies. It might make more > > sense to create a --proper=yes flag, where it searches the system for the > > dependencies, and fails if it can not find them. > > Timothy St. Clair wrote: > You can still leverage the CPPFLAGS & LDFLAGS as before.
Or perhaps --proper could enable --without-*, that seems like the cleanest solution. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review36642 ----------------------------------------------------------- On March 10, 2014, 10:36 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 10:36 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas > Nielsen, Timothy St. Clair, and Vinod Kone. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of the currently bundled leveldb in favor of a > preinstalled version. > > > Diffs > ----- > > 3rdparty/Makefile.am 8e1d915 > configure.ac 390f11b > src/Makefile.am 384b312 > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > OSX: brew installed leveldb comes with activated libsnappy > ../configure --without-included-leveldb CPPFLAGS=-I/usr/local/include > LDFLAGS=-L/usr/local/lib LIBS="-lleveldb -lsnappy" > make check > > linux: manually installed leveldb without libsnappy > ../configure --without-included-leveldb CPPFLAGS=-I/usr/local/include > LDFLAGS=-L/usr/local/lib LIBS=-lleveldb > make check > > > Thanks, > > Till Toenshoff > >
