> On March 20, 2014, 4:46 p.m., Benjamin Hindman wrote: > > Just so I understand clearly, do we not want to allow people to try and use > > system installed libraries but fall back on what's bundled otherwise? > > Consider someone who has leveldb installed with snappy, so they'd like to > > use the system installed leveldb but use everything else that is bundled so > > they don't have to go install all those things, can they do that? > > > > Also, I agree with Adam that --enable-proper isn't as descriptive as say, > > --with-installed-dependencies.
The point that Vinod made on the ticket was: "I would prefer to also have an option to always use bundled dependencies irrespective of system installed ones. In fact this could be the default so as to not break users that are already expect this behavior. After a deprecation period we could change the default to prefer system installed dependencies." That is how the patch was setup. I personally like --disable-bundled, but I don't have strong opinions on the matter. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review37907 ----------------------------------------------------------- On March 17, 2014, 7:51 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 7:51 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --enable-proper generally switches from bundled to preinstalled libraries. > This review only implements this preinstalled library usage on LevelDB. For > using the preinstalled LevelDB from a location that is not part of the > standard include and linker paths, you may specify --with-leveldb=PREFIX_PATH. > > If --enable-proper is supplied, the configuration phase will attempt to > locate the needed headers as well as the library itself. > > If --enable-proper is not supplied, the bundled library is built and used. > > NOTE: Subsequent review requests for other bundled libraries will follow as > soon as this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 9a6de87 > src/Makefile.am 0775a0d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --enable-proper --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --enable-proper > make check > > > Thanks, > > Till Toenshoff > >
