----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19006/#review36751 -----------------------------------------------------------
Patch looks great! Reviews applied: [19006] All tests passed. - Mesos ReviewBot On March 11, 2014, 2:18 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19006/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 2:18 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Moved slave deactivation code out of Master::exited() into new > deactivate(Slave). > > Still need to reconcile this code with deactivateSlave(SlaveId) which right > now just calls removeSlave(Slave). > From what I can tell, checkpointing slaves can just be deactivated, but > non-checkpointing slaves get removed altogether. Correct? > I welcome thoughts/suggestions on how to clean this up. > > > Diffs > ----- > > src/master/master.hpp 49a3e15 > src/master/master.cpp 2a40333 > > Diff: https://reviews.apache.org/r/19006/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
