----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19006/#review37684 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/19006/#comment69326> I applaud the effort here to clean this up but it looks like the meaning of the words used for slave states are inconsistent now: 1. The SlaveObserver "disconnects" a slave, which shuts the slave down, and marks it as "deactivated" once removed. 2. We have "deactivate", which marks the slave as "disconnected". Seems like we should either keep the terminology consistent or choose better terminology if we feel "activated" and "deactivated" were a poor choice in retrospect. - Ben Mahler On March 19, 2014, 2:59 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19006/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 2:59 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Moved slave deactivation code out of Master::exited() into new > deactivate(Slave). > > > Diffs > ----- > > src/master/master.hpp 0c7c520 > src/master/master.cpp 6da7766 > > Diff: https://reviews.apache.org/r/19006/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
