----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19009/#review36794 -----------------------------------------------------------
src/state/in_memory.hpp <https://reviews.apache.org/r/19009/#comment67983> It doesn't look like you need all these headers. dispatch and process are probably superfluous, you could forward declare UUID (i think). src/state/in_memory.cpp <https://reviews.apache.org/r/19009/#comment67984> I don't see list used anywhere src/state/in_memory.cpp <https://reviews.apache.org/r/19009/#comment67985> why convert from hashset to vector? src/state/in_memory.cpp <https://reviews.apache.org/r/19009/#comment67986> could this be in the initializer list? src/state/in_memory.cpp <https://reviews.apache.org/r/19009/#comment67987> remove a newline - Dominic Hamon On March 10, 2014, 8:46 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19009/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 8:46 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > This adds an in-memory storage implementation, similar to what we have for > InMemoryState.java. > > I will be using this to enable us to commit Registrar integration with the > Master without changing any of the existing behavior. > > > Diffs > ----- > > src/Makefile.am 384b3122b61294401ba4a894c06e985d9fc2fb1e > src/state/in_memory.hpp PRE-CREATION > src/state/in_memory.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19009/diff/ > > > Testing > ------- > > make check (no tests exist for the existing state implementations so I did > not add one for this, I will follow up with tests) > > > Thanks, > > Ben Mahler > >
