> On March 11, 2014, 4:43 p.m., Dominic Hamon wrote: > > src/state/in_memory.cpp, line 65 > > <https://reviews.apache.org/r/19009/diff/1/?file=515967#file515967line65> > > > > why convert from hashset to vector?
As opposed to? The Storage interface is defined to return a vector for names() (see storage.hpp). > On March 11, 2014, 4:43 p.m., Dominic Hamon wrote: > > src/state/in_memory.cpp, line 79 > > <https://reviews.apache.org/r/19009/diff/1/?file=515967#file515967line79> > > > > could this be in the initializer list? It definitely could be, but all of our 'Process' wrappers use this style at the current time, so I'll keep it consistent. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19009/#review36794 ----------------------------------------------------------- On March 11, 2014, 3:46 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19009/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 3:46 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > This adds an in-memory storage implementation, similar to what we have for > InMemoryState.java. > > I will be using this to enable us to commit Registrar integration with the > Master without changing any of the existing behavior. > > > Diffs > ----- > > src/Makefile.am 384b3122b61294401ba4a894c06e985d9fc2fb1e > src/state/in_memory.hpp PRE-CREATION > src/state/in_memory.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19009/diff/ > > > Testing > ------- > > make check (no tests exist for the existing state implementations so I did > not add one for this, I will follow up with tests) > > > Thanks, > > Ben Mahler > >
