> On March 13, 2014, 11:38 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 137-138 > > <https://reviews.apache.org/r/19162/diff/3/?file=519501#file519501line137> > > > > What does "= delete" mean? Perhaps use the same comment from other > > places in the code: > > > > // Not copyable, not assignable. > > Promise(const Promise<T>&); > > Promise<T>& operator = (const Promise<T>&);
I wonder if it's worth having a macro to make this easier: #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ TypeName(const TypeName&); \ TypeName& operator = (const TypeName&) > On March 13, 2014, 11:38 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 17 > > <https://reviews.apache.org/r/19162/diff/3/?file=519502#file519502line17> > > > > Anonymous namespaces are, as far as I know, new style in libprocess. > > Did you need this? Need it? No. But it does make it so that the symbols aren't available outside the translation unit. Ie, I can ensure that noone else is calling cleanup/using Envp so I won't break people inadvertently if I change them. > On March 13, 2014, 11:38 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 54 > > <https://reviews.apache.org/r/19162/diff/3/?file=519502#file519502line54> > > > > Why are you using 'malloc', instead of 'new'? That is, if you need to, > > a comment would be nice! because i'm dealing with basic types that don't have constructors. new[] and delete[] could be used just as well if that's prefered. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review37167 ----------------------------------------------------------- On March 13, 2014, 5:46 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 5:46 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/subprocess.hpp > d16cbc1e3d464e1784f116ccdb327cf0784f07c2 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
