> On March 18, 2014, 10:57 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 52 > > <https://reviews.apache.org/r/19162/diff/5/?file=523512#file523512line52> > > > > It would only really change line 71. Given the execle call expects a > > char** eventually, i'd rather keep it in that form from the beginning. > > Ben Mahler wrote: > If you reply from the main review page, then the thread of conversation > will be kept intact.
Can't we pass &envp_[0] to execle? - Nikita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review37657 ----------------------------------------------------------- On March 17, 2014, 7:33 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 7:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/subprocess.hpp > 75b2a96b3ca62a4a59e64aba046f1d797bd8ebf6 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
