> On March 25, 2014, 3:41 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 82 > > <https://reviews.apache.org/r/18718/diff/14/?file=535937#file535937line82> > > > > Kill std:: and s/metricValues/values/ ? > > > > Let's try to keep the name consistent between here and the > > continuation, here you're passing 'metricValues' and the continuation calls > > this 'metrics'. Why not just call them 'values' in both places?
metrics - because the list is called 'values' which is more correct. > On March 25, 2014, 3:41 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 51 > > <https://reviews.apache.org/r/18718/diff/14/?file=535938#file535938line51> > > > > Why the double negation? copied from elsewhere :) - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review38544 ----------------------------------------------------------- On March 25, 2014, 3:57 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 3:57 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/metrics/counter.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/gauge.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metric.cpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
