> On March 25, 2014, 4:15 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, lines 145-146 > > <https://reviews.apache.org/r/18718/diff/15/?file=536322#file536322line145> > > > > Each on it's own line, consider wrapping at the ( since this is a short > > line.
> On March 25, 2014, 4:15 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 18 > > <https://reviews.apache.org/r/18718/diff/15/?file=536323#file536323line18> > > > > Why this typedef with TEST_F as opposed to just TEST? (Compare to > > hashmap_tests.cpp) i am future-proofing should we need state later on for JSON equality or more complex tests. > On March 25, 2014, 4:15 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 50 > > <https://reviews.apache.org/r/18718/diff/15/?file=536323#file536323line50> > > > > The managed process semantics will manage the pointer passed in for you > > in terms of deleting it once it terminates. Did the test pass like this? > > > > I would recommend not managing and calling terminate and wait at the > > end of the test. it did, but i can see that this might be flaky. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review38553 ----------------------------------------------------------- On March 25, 2014, 3:57 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 3:57 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/metrics/counter.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/gauge.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metric.cpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
