> On March 28, 2014, 2:50 a.m., Jie Yu wrote: > > src/zookeeper/zookeeper.cpp, line 523 > > <https://reviews.apache.org/r/19719/diff/1/?file=538261#file538261line523> > > > > Would you please use stout/unreachable.hpp > > > > #include <stout/unreachable.hpp> > > > > ... > > return UNREACHABLE();
Great to know that, thanks, will upload new version - Chengwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19719/#review38784 ----------------------------------------------------------- On March 27, 2014, 5:24 p.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19719/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 5:24 p.m.) > > > Review request for mesos, Jie Yu, Vinod Kone, and Vinson Lee. > > > Bugs: MESOS-1134 > https://issues.apache.org/jira/browse/MESOS-1134 > > > Repository: mesos-git > > > Description > ------- > > Build: make intel compiler happy > > > Diffs > ----- > > src/zookeeper/zookeeper.cpp e27312d91fa4d85e0507a3e312043bc7337fe9a4 > > Diff: https://reviews.apache.org/r/19719/diff/ > > > Testing > ------- > > didn't tested with icpc, but not break build with gcc/g++ > > > Thanks, > > Chengwei Yang > >
