> On March 28, 2014, 12:25 p.m., Jie Yu wrote: > > src/zookeeper/zookeeper.cpp, line 527 > > <https://reviews.apache.org/r/19719/diff/2/?file=539346#file539346line527> > > > > Can you remove the comments here as the "UNREACHABLE" macro is already > > very explicit and readable.
Sure, just add a simple comment for mesos newbie, like me. - Chengwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19719/#review38869 ----------------------------------------------------------- On March 28, 2014, 12:40 p.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19719/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 12:40 p.m.) > > > Review request for mesos, Jie Yu, Vinod Kone, and Vinson Lee. > > > Bugs: MESOS-1134 > https://issues.apache.org/jira/browse/MESOS-1134 > > > Repository: mesos-git > > > Description > ------- > > Build: make intel compiler happy > > Review: https://reviews.apache.org/r/19719 > > > Diffs > ----- > > src/zookeeper/zookeeper.cpp e27312d91fa4d85e0507a3e312043bc7337fe9a4 > > Diff: https://reviews.apache.org/r/19719/diff/ > > > Testing > ------- > > didn't tested with icpc, but not break build with gcc/g++ > > > Thanks, > > Chengwei Yang > >
