> On March 31, 2014, 6:57 p.m., Chi Zhang wrote: > > src/linux/routing.cpp, line 145 > > <https://reviews.apache.org/r/19702/diff/4/?file=540352#file540352line145> > > > > Reminder: Confirm that cleaning up cache won't clean up the link > > returned.
Since all unit test passes without problems (with --gtest_repeat=100), I think this should not be an issue. But I'll keep that in mind. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39082 ----------------------------------------------------------- On March 29, 2014, 5:59 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19702/ > ----------------------------------------------------------- > > (Updated March 29, 2014, 5:59 a.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > UPDATE: > > 1) adjusted a few interfaces per review comments. > 2) added impl. (including tests) for managing links. > > I'll be adding impl. for managing filters soon (currently, they return > Error("Unimplemented").) > > > ------ > > Hey guys, I send this review in order to get an idea about the interface > design. > > Feel free to jump in to express your thoughts, suggestions, concerns, etc. > > Thanks! > > > Diffs > ----- > > configure.ac 5404dc2 > src/Makefile.am 47d03b3 > src/linux/routing.hpp PRE-CREATION > src/linux/routing.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19702/diff/ > > > Testing > ------- > > make check > > sudo make check > > > Thanks, > > Jie Yu > >
