----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/ -----------------------------------------------------------
(Updated April 3, 2014, 2:15 a.m.) Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. Changes ------- Added impl. for IP packet filter. Repository: mesos-git Description (updated) ------- UPDATE: Added impl. (including tests) for managing IP packet filter. ------ 1) adjusted a few interfaces per review comments. 2) added impl. (including tests) for managing links. I'll be adding impl. for managing filters soon (currently, they return Error("Unimplemented").) ------ Hey guys, I send this review in order to get an idea about the interface design. Feel free to jump in to express your thoughts, suggestions, concerns, etc. Thanks! Diffs (updated) ----- configure.ac 5404dc2 src/Makefile.am 95f133d src/linux/routing.hpp PRE-CREATION src/linux/routing.cpp PRE-CREATION src/tests/routing_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/19702/diff/ Testing ------- make check sudo make check Thanks, Jie Yu