> On April 1, 2014, 11:51 a.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, lines 3502-3514 > > <https://reviews.apache.org/r/19795/diff/2/?file=543982#file543982line3502> > > > > I chatted with BenH about this and I think we have an approach to do > > proper clean-up of orphan containers. Updated RR will follow.
I took a stab at it in the latest patch. If the executor info is not present in the directory (which will be the case if the slave fails over during launch), the executor state will still be available (as we create the directory up front, just without the info saved). The new patch destroys the container if this happens. I am still thinking about a good test for this and am open to suggestions. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19795/#review39190 ----------------------------------------------------------- On April 1, 2014, 6:45 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19795/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 6:45 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-922 > https://issues.apache.org/jira/browse/MESOS-922 > > > Repository: mesos-git > > > Description > ------- > > This is the 2nd part of the task-info patch split > (https://reviews.apache.org/r/18403/) and changes Executor::info to an > executor info future. > This is motivated by delegating executor info creation/choice to the > containerizer to address new container/executor scenarios > (https://issues.apache.org/jira/browse/MESOS-922). > > This patch use the new Executor::info and introduces new continuations to > deal with launching containers i.e. executor infos are to be determined. > > > Diffs > ----- > > src/slave/http.cpp 594032d > src/slave/slave.hpp 15e23ce > src/slave/slave.cpp a356f5f > > Diff: https://reviews.apache.org/r/19795/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
