> On April 7, 2014, 11:33 a.m., Ian Downes wrote: > > src/slave/slave.cpp, line 992 > > <https://reviews.apache.org/r/19795/diff/3/?file=544927#file544927line992> > > > > I believe Vinod is saying the future argument to __runTask is the same > > as the member variable executor->info. You can do any error checking on the > > member variable, after you look up the Executor.
That is only in the case of __runTask(), but think it is the general theme of passing the lambda along with the value isn't used directly (other than error checking). - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19795/#review39699 ----------------------------------------------------------- On April 7, 2014, 4:53 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19795/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 4:53 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-922 > https://issues.apache.org/jira/browse/MESOS-922 > > > Repository: mesos-git > > > Description > ------- > > This is the 2nd part of the task-info patch split > (https://reviews.apache.org/r/18403/) and changes Executor::info to an > executor info future. > This is motivated by delegating executor info creation/choice to the > containerizer to address new container/executor scenarios > (https://issues.apache.org/jira/browse/MESOS-922). > > This patch use the new Executor::info and introduces new continuations to > deal with launching containers i.e. executor infos are to be determined. > > > Diffs > ----- > > src/slave/http.cpp 594032d > src/slave/slave.hpp 15e23ce > src/slave/slave.cpp a356f5f > > Diff: https://reviews.apache.org/r/19795/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
