----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20127/#review39935 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20127/#comment72703> s/thus/which/ 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20127/#comment72705> I agree with Ian, lets just return status. I think its more flexible (for e.g: users could do WTERMSIG(status)). - Vinod Kone On April 9, 2014, 7:43 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20127/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 7:43 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp db5ae69 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp d61db30 > > Diff: https://reviews.apache.org/r/20127/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
