----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20119/#review39944 -----------------------------------------------------------
Ship it! I think this is a good semantics for now even if we decide to add more functionality later so let's get this committed after some minor cleanups. 3rdparty/Makefile.am <https://reviews.apache.org/r/20119/#comment72728> Why is this necessary? Comment please? configure.ac <https://reviews.apache.org/r/20119/#comment72713> s/attempt detecting/to attempt to detect/ configure.ac <https://reviews.apache.org/r/20119/#comment72712> Can a user just do --with-zookeeper without specifying a directory? That would imply 'without_bundled_zookeeper=yes' and we just wouldn't update CPPFLAGS and LDFLAGS? configure.ac <https://reviews.apache.org/r/20119/#comment72714> No newline above, kill this one too? configure.ac <https://reviews.apache.org/r/20119/#comment72711> s/asked us use/asked us to use/ s/he/they/ configure.ac <https://reviews.apache.org/r/20119/#comment72726> How about: You have requested the use of a non-bundled LevelDB but no suitable LevelDB could be found. configure.ac <https://reviews.apache.org/r/20119/#comment72727> Can we add "(or check that the path you provided is correct if you're already doing this)" to the end of this sentence please? configure.ac <https://reviews.apache.org/r/20119/#comment72715> s/asked us use/asked us to use/ s/he/they/ configure.ac <https://reviews.apache.org/r/20119/#comment72717> Let's move these up to where the work is now please. src/Makefile.am <https://reviews.apache.org/r/20119/#comment72730> This comment should be inside the 'if' please. src/Makefile.am <https://reviews.apache.org/r/20119/#comment72731> I don't think this does anything. src/python/setup.py.in <https://reviews.apache.org/r/20119/#comment72733> s/lzookp/libzookeeper/ - Benjamin Hindman On April 8, 2014, 2:21 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20119/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 2:21 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 and MESOS-1168 > https://issues.apache.org/jira/browse/MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1168 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > > If --disable-bundled is supplied or --with-leveldb[=DIR] was given but the > configuration phase could not locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb[=DIR] was given, > the bundled library is built and used (DEFAULT). > > NOTE: > 1. This review only implements this preinstalled library usage on LevelDB & > ZooKeeper. Subsequent review requests for other bundled libraries will follow > as soon as this implementation has been accepted. > > 2. This modification removed the old --without-installed-PACKAGE semantics, > as they conflict with well established --with-PACKAGE semantics > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac c1de6d7 > src/Makefile.am 95f133d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/20119/diff/ > > > Testing > ------- > > make check across all combinatoric incantations. > > > Thanks, > > Timothy St. Clair > >
