> On April 9, 2014, 10:22 p.m., Benjamin Hindman wrote: > > 3rdparty/Makefile.am, lines 84-85 > > <https://reviews.apache.org/r/20119/diff/2/?file=552587#file552587line84> > > > > Why is this necessary? Comment please?
I've went through this again and made further modifications, patch coming. > On April 9, 2014, 10:22 p.m., Benjamin Hindman wrote: > > configure.ac, line 218 > > <https://reviews.apache.org/r/20119/diff/2/?file=552588#file552588line218> > > > > Can a user just do --with-zookeeper without specifying a directory? > > That would imply 'without_bundled_zookeeper=yes' and we just wouldn't > > update CPPFLAGS and LDFLAGS? That's what the code implies, and it will try to detect zookeeper using its existing CPPFLAGS & LDFLAGS. > On April 9, 2014, 10:22 p.m., Benjamin Hindman wrote: > > src/Makefile.am, lines 409-410 > > <https://reviews.apache.org/r/20119/diff/2/?file=552589#file552589line409> > > > > I don't think this does anything. That was a remnant from the original patch that I had missed. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20119/#review39944 ----------------------------------------------------------- On April 8, 2014, 2:21 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20119/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 2:21 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 and MESOS-1168 > https://issues.apache.org/jira/browse/MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1168 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > > If --disable-bundled is supplied or --with-leveldb[=DIR] was given but the > configuration phase could not locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb[=DIR] was given, > the bundled library is built and used (DEFAULT). > > NOTE: > 1. This review only implements this preinstalled library usage on LevelDB & > ZooKeeper. Subsequent review requests for other bundled libraries will follow > as soon as this implementation has been accepted. > > 2. This modification removed the old --without-installed-PACKAGE semantics, > as they conflict with well established --with-PACKAGE semantics > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac c1de6d7 > src/Makefile.am 95f133d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/20119/diff/ > > > Testing > ------- > > make check across all combinatoric incantations. > > > Thanks, > > Timothy St. Clair > >
