> On April 10, 2014, 7:57 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, lines 76-77 > > <https://reviews.apache.org/r/18718/diff/27/?file=554568#file554568line76> > > > > I still think collapsing these is worth doing, unless I'm missing > > something. > > Dominic Hamon wrote: > i posted the error message i get as a comment above. essentially > futures.values() is not an lvalue. It's surprising, but this seems necessary.
Is it because await takes a non-const reference? Can you try fixing await and collect to take const references? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review40073 ----------------------------------------------------------- On April 10, 2014, 8:31 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 8:31 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c785c4dd852eacaec1be11c68e0b0b95a328d96b > 3rdparty/libprocess/include/process/metrics/counter.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/gauge.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metrics.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
