----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review40088 -----------------------------------------------------------
Ship it! Made some comments below but I will clean most of them up and get this committed! 3rdparty/libprocess/include/process/metrics/counter.hpp <https://reviews.apache.org/r/18718/#comment72912> Looks like this doesn't need to take an argument? 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/18718/#comment72929> We no longer need this include, right? 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/18718/#comment72928> s/n/_name/? 3rdparty/libprocess/include/process/metrics/metrics.hpp <https://reviews.apache.org/r/18718/#comment72914> I'll move this down to below the snapshot method so that the continuation is in order. 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/18718/#comment72926> Per discussion, I'll remove this line for you. 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/18718/#comment72927> Maybe we should consider putting a 'NaN' in here so that the metric at least remains visible? Something to consider. 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/18718/#comment72918> Maybe we should follow up with some example JSON in the help output? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/18718/#comment72919> Maybe we should call this 'fail' now that it's no longer an option? - Ben Mahler On April 10, 2014, 8:58 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 8:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c785c4dd852eacaec1be11c68e0b0b95a328d96b > 3rdparty/libprocess/include/process/metrics/counter.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/gauge.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metrics.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
