> On April 24, 2014, 4:16 p.m., Benjamin Hindman wrote: > > 3rdparty/Makefile.am, lines 100-102 > > <https://reviews.apache.org/r/20119/diff/5/?file=564555#file564555line100> > > > > Unless I'm missing something we still need to extract ZooKeeper even if > > we're using an installed libzookeeper_mt because we need the ZooKeeper jar > > to do make check (see > > https://github.com/apache/mesos/blob/master/src/tests/zookeeper.cpp#L60). > > > > In order to fully unbundle ZooKeeper we'll need to fix how we get the > > ZooKeeper jar. Some suggestions: (1) bundle just the ZooKeeper jar > > (simplest short term solution) or (2) update pom.xml to have Maven pull it > > down for us during a build (a good long term solution but depends on the > > current Maven changes being made by Tobi Knaup getting committed; also, > > this will mean we now require internet access for builds, but oh well) or > > (3) update configure to point to/find the ZooKeeper jar. > > > > In the mean time I think we should just extract ZooKeeper regardless.
I'll do 1 for now, but 2 is much better. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20119/#review41318 ----------------------------------------------------------- On April 22, 2014, 3:26 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20119/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 3:26 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 and MESOS-1168 > https://issues.apache.org/jira/browse/MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1168 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > > If --disable-bundled is supplied or --with-leveldb[=DIR] was given but the > configuration phase could not locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb[=DIR] was given, > the bundled library is built and used (DEFAULT). > > NOTE: > 1. This review only implements this preinstalled library usage on LevelDB & > ZooKeeper. Subsequent review requests for other bundled libraries will follow > as soon as this implementation has been accepted. > > 2. This modification removed the old --without-installed-PACKAGE semantics, > as they conflict with well established --with-PACKAGE semantics > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac c1de6d7 > src/Makefile.am a44ea42 > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/20119/diff/ > > > Testing > ------- > > make check across all combinatoric incantations. > > > Thanks, > > Timothy St. Clair > >
