> On April 11, 2014, 11:53 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [20119] > > > > Failed command: make -j3 check GTEST_FILTER='' >/dev/null > > > > Error: > > ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared > > 'extern' [enabled by default] > > ev.c: In function 'evpipe_write': > > ev.c:2160:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2172:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c: In function 'pipecb': > > ev.c:2193:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2207:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > In file included from /usr/include/c++/4.6/ext/hash_set:61:0, > > from src/glog/stl_logging.h:54, > > from src/stl_logging_unittest.cc:34: > > /usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning > > This file includes at least one deprecated or antiquated header which may > > be removed without further notice at a future date. Please use a > > non-deprecated interface with equivalent functionality instead. For a > > listing of replacement headers and interfaces, consult the file > > backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp] > > In file included from src/utilities.h:73:0, > > from src/googletest.h:38, > > from src/stl_logging_unittest.cc:48: > > src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by > > default] > > /usr/include/features.h:166:0: note: this is the location of the previous > > definition > > warning: no files found matching 'Makefile' under directory 'docs' > > warning: no files found matching 'indexsidebar.html' under directory 'docs' > > zip_safe flag not set; analyzing archive contents... > > WARNING: '.' not a valid package name; please use only.-separated package > > names in setup.py > > package init file 'src/__init__.py' not found (or not a regular file) > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > zip_safe flag not set; analyzing archive contents... > > Note: Some input files use or override a deprecated API. > > Note: Recompile with -Xlint:deprecation for details. > > make[3]: *** [check-local] Segmentation fault > > make[2]: *** [check-am] Error 2 > > make[1]: *** [check] Error 2 > > make: *** [check-recursive] Error 1 > >
I think the compiler died ^ - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20119/#review40190 ----------------------------------------------------------- On April 11, 2014, 4:29 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20119/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 4:29 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 and MESOS-1168 > https://issues.apache.org/jira/browse/MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1168 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > > If --disable-bundled is supplied or --with-leveldb[=DIR] was given but the > configuration phase could not locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb[=DIR] was given, > the bundled library is built and used (DEFAULT). > > NOTE: > 1. This review only implements this preinstalled library usage on LevelDB & > ZooKeeper. Subsequent review requests for other bundled libraries will follow > as soon as this implementation has been accepted. > > 2. This modification removed the old --without-installed-PACKAGE semantics, > as they conflict with well established --with-PACKAGE semantics > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac c1de6d7 > src/Makefile.am 95f133d > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/20119/diff/ > > > Testing > ------- > > make check across all combinatoric incantations. > > > Thanks, > > Timothy St. Clair > >
