> On April 25, 2014, 2:24 p.m., Ben Mahler wrote: > > Awesome, are you planning to integrate this into the Registrar too? :D
sure .. in another patch. > On April 25, 2014, 2:24 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 84 > > <https://reviews.apache.org/r/20593/diff/2/?file=565984#file565984line84> > > > > Alternatively, we could just use the Clock without any additional > > complexity and with better testability (no need to sleep, etc) in tests. > > > > Any reason to prefer Stopwatch? We could move to using Clock::now for > > start()/stop() and it would be easier to test that we're correctly timing > > things. I have no preference - i chose the lowest-level abstraction that made sense. You want a change to Clock in this patch? > On April 25, 2014, 2:24 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 86 > > <https://reviews.apache.org/r/20593/diff/2/?file=565984#file565984line86> > > > > To be even more explicit, how about: > > > > future > > .onAny(...); > > > > return future; > > > > (Normally we'll place callbacks on separate lines) not: Future<T> future = future_ .onAny(...); return future; ? I expected to have to return the future from onAny rather than the future that's passed in. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20593/#review41529 ----------------------------------------------------------- On April 23, 2014, 11:55 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20593/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 11:55 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/timer.hpp > c8e1d91bdc39fb0702bc761e98807abdade4996d > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 6f3795b33b92dd0621867e274649f8b9667ba538 > > Diff: https://reviews.apache.org/r/20593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
