----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20593/#review41846 -----------------------------------------------------------
Ship it! Thanks Dominic, I will get this committed! Would be fantastic if we could use 'Clock' to accurately test that Timer is measuring the right thing. :) - Ben Mahler On April 25, 2014, 11:29 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20593/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 11:29 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/timer.hpp > c8e1d91bdc39fb0702bc761e98807abdade4996d > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 294aed424983bbbcaf74c0417c6bcd36a496acb7 > > Diff: https://reviews.apache.org/r/20593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
