----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review41569 -----------------------------------------------------------
Ship it! I've made the minor style cleanups mentioned in this review so I'll be committing this now. src/examples/python/test_containerizer.py <https://reviews.apache.org/r/17567/#comment75075> Minor nit: s/container/argv0/ src/examples/python/test_containerizer.py <https://reviews.apache.org/r/17567/#comment75089> Minor nit: s/container/argv0/ src/slave/containerizer/external_containerizer.hpp <https://reviews.apache.org/r/17567/#comment75090> This is now dead code! src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/17567/#comment75096> We actually wrap these just like other expressions (e.g., boolean expressions), see http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Boolean_Expressions#Boolean_Expressions. src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/17567/#comment75099> Okay, while I agree that there isn't too much we need to do, my guess is that we need to at least fill up the list of containers so that subsequent calls to things like 'wait', 'usage', 'update', etc. will work! src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/17567/#comment75094> This needs to call out to the external containerizer program! This could return nothing after a slave recovers! src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/17567/#comment75092> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Boolean_Expressions#Boolean_Expressions src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/17567/#comment75091> +4 here. src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/17567/#comment75093> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Boolean_Expressions#Boolean_Expressions src/tests/external_containerizer_test.cpp <https://reviews.apache.org/r/17567/#comment75109> const & src/tests/external_containerizer_test.cpp <https://reviews.apache.org/r/17567/#comment75110> +2 here. src/tests/external_containerizer_test.cpp <https://reviews.apache.org/r/17567/#comment75111> CopyFrom (not your bug, but don't hesitate to clean this up when you copy/paste). - Benjamin Hindman On April 26, 2014, 1:14 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 1:14 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Niklas Nielsen. > > > Bugs: MESOS-816 > https://issues.apache.org/jira/browse/MESOS-816 > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called external containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). > > The protocol for the interactions with the external program > is as follows: > > COMMAND < INPUT-PROTO > RESULT-PROTO > > launch < Launch > update < Update > usage < Usage > ResourceStatistics > wait < Wait > Termination > destroy < Destroy > > When protocol buffers need to be provided, the Mesos side of > the external containerizer implementation will serialize the > protos on stdin and vice-versa for reading protos on stdout as > drafted in the above scheme. > > > Diffs > ----- > > configure.ac c964452 > src/Makefile.am 364d63b > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.hpp 9a50fba > src/slave/containerizer/containerizer.cpp 344872a > src/slave/containerizer/external_containerizer.hpp PRE-CREATION > src/slave/containerizer/external_containerizer.cpp PRE-CREATION > src/slave/containerizer/mesos_containerizer.cpp f5df979 > src/slave/flags.hpp d5c54c0 > src/tests/external_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Till Toenshoff > >
