> On April 28, 2014, 7:08 a.m., Benjamin Hindman wrote: > > I've made the minor style cleanups mentioned in this review so I'll be > > committing this now.
Thank you so much Ben - especially for doing my work and fixing these remaining issues. > On April 28, 2014, 7:08 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/external_containerizer.cpp, line 745 > > <https://reviews.apache.org/r/17567/diff/23/?file=569035#file569035line745> > > > > This needs to call out to the external containerizer program! This > > could return nothing after a slave recovers! Great point indeed. Will propose a subsequent patch. One question though, what about discrepancies; Suppose the ECP returns containerIDs A and B whereas the internal state of the EC knows about containerIDs A, B and C. I will need to check if that is actually a reasonable scenario but there is potential for a challenge here :). > On April 28, 2014, 7:08 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/external_containerizer.cpp, lines 284-286 > > <https://reviews.apache.org/r/17567/diff/23/?file=569035#file569035line284> > > > > Okay, while I agree that there isn't too much we need to do, my guess > > is that we need to at least fill up the list of containers so that > > subsequent calls to things like 'wait', 'usage', 'update', etc. will work! Will propose an RR for this. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review41569 ----------------------------------------------------------- On April 26, 2014, 1:14 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 1:14 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Niklas Nielsen. > > > Bugs: MESOS-816 > https://issues.apache.org/jira/browse/MESOS-816 > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called external containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). > > The protocol for the interactions with the external program > is as follows: > > COMMAND < INPUT-PROTO > RESULT-PROTO > > launch < Launch > update < Update > usage < Usage > ResourceStatistics > wait < Wait > Termination > destroy < Destroy > > When protocol buffers need to be provided, the Mesos side of > the external containerizer implementation will serialize the > protos on stdin and vice-versa for reading protos on stdout as > drafted in the above scheme. > > > Diffs > ----- > > configure.ac c964452 > src/Makefile.am 364d63b > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.hpp 9a50fba > src/slave/containerizer/containerizer.cpp 344872a > src/slave/containerizer/external_containerizer.hpp PRE-CREATION > src/slave/containerizer/external_containerizer.cpp PRE-CREATION > src/slave/containerizer/mesos_containerizer.cpp f5df979 > src/slave/flags.hpp d5c54c0 > src/tests/external_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Till Toenshoff > >
