----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21013/#review42344 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp <https://reviews.apache.org/r/21013/#comment76129> Any reason not to check path to see if we've already opened a library rather than always trying to do a 'dlclose'? Same down below in 'DynamicLibrary::loadSymbol', any reason trying to do 'dlsym' if we haven't already done an open? Maybe 'dlclose' and 'dlsym' "does the right thing" but the error message would be much cleaner if we just said something like "Attempted to close a library that hasn't been closed" or "Attempted to load a symbol from an unopened library" rather than "Error looking up symbol: Bad input" (or whatever 'dlerror' would return when you pass it a NULL handle. The same applies for the DynamicLibrary::open call as well as I gave in a previous review. - Benjamin Hindman On May 6, 2014, 7:05 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21013/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 7:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1224 > https://issues.apache.org/jira/browse/MESOS-1224 > > > Repository: mesos-git > > > Description > ------- > > Addition of DynamicLibrary class to stout, to enable future plugins inside of > mesos. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 980146b > 3rdparty/libprocess/3rdparty/stout/Makefile.am aa1d0a5 > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > PRE-CREATION > 3rdparty/libprocess/configure.ac 0c7cc6d > > Diff: https://reviews.apache.org/r/21013/diff/ > > > Testing > ------- > > New test has been added and ran 'make check' around Mac and Linux > > > Thanks, > > Timothy St. Clair > >
