> On May 6, 2014, 7:17 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp, line 33 > > <https://reviews.apache.org/r/21013/diff/5/?file=574990#file574990line33> > > > > You don't need 'this->' and we typically omit it unless necessary.
Didn't see your update, please drop this issue. > On May 6, 2014, 7:17 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp, line 28 > > <https://reviews.apache.org/r/21013/diff/5/?file=574990#file574990line28> > > > > Why not use an Option for 'path_' instead of a sentinel value? Didn't see your update, cool! Please drop this issue. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21013/#review42328 ----------------------------------------------------------- On May 6, 2014, 7:05 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21013/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 7:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1224 > https://issues.apache.org/jira/browse/MESOS-1224 > > > Repository: mesos-git > > > Description > ------- > > Addition of DynamicLibrary class to stout, to enable future plugins inside of > mesos. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 980146b > 3rdparty/libprocess/3rdparty/stout/Makefile.am aa1d0a5 > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > PRE-CREATION > 3rdparty/libprocess/configure.ac 0c7cc6d > > Diff: https://reviews.apache.org/r/21013/diff/ > > > Testing > ------- > > New test has been added and ran 'make check' around Mac and Linux > > > Thanks, > > Timothy St. Clair > >
