----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21092/#review42526 -----------------------------------------------------------
Ship it! Thanks! I'll get this committed, just had a few things to clean up from the comments below. I removed some Clock::advance calls that look unnecessary, let me know if there was a reason they're needed! 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/21092/#comment76319> Looks like this input validation should be at the top, before we start the computation? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76324> Why the slightly different order here? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76320> I'll add to this test to make sure the validation returns BadRequest as well! 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76321> Looks like we don't need this? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76322> We should probably check that it's still pending after a Clock::settle here, I'll add that. 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76323> Why the slightly different order here? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76325> Why is this one needed? - Ben Mahler On May 8, 2014, 6:21 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21092/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 6:21 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1287 > https://issues.apache.org/jira/browse/MESOS-1287 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > d5176ee4375febff26f52f167ead39a8303b54f9 > 3rdparty/libprocess/src/metrics/metrics.cpp > bb36c729532ce9a2ffad51d5b25e95355a78abad > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 9f04b9bff8f747176f009b3a9120521490bcc222 > > Diff: https://reviews.apache.org/r/21092/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
