----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21092/#review42434 -----------------------------------------------------------
Looks good, I think it would be more flexible to make the timeout a query parameter instead of a fixed constant, so that people can adjust as needed! 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/21092/#comment76226> Should the default be ? (or say, 1 hour) and people can specify a timeout as a query parameter? That way, people can just change the URL in order to tune this to their particular needs. 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/21092/#comment76227> brace on newline 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/21092/#comment76228> Maybe we should re-order these cases to handles the exceptional cases first? Can the log message include the timeout duration? 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/21092/#comment76232> Let's just kill this logical case but leave the TODO? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76229> How about s/timeout/pending/ 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76230> This seems unnecessary in this patch? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/21092/#comment76231> Why 10 seconds if the constant is 5? Ditto above. - Ben Mahler On May 6, 2014, 9:19 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21092/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 9:19 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1287 > https://issues.apache.org/jira/browse/MESOS-1287 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > d5176ee4375febff26f52f167ead39a8303b54f9 > 3rdparty/libprocess/src/metrics/metrics.cpp > bb36c729532ce9a2ffad51d5b25e95355a78abad > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 9f04b9bff8f747176f009b3a9120521490bcc222 > > Diff: https://reviews.apache.org/r/21092/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
