----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21966/#review44193 -----------------------------------------------------------
Quite the tricky bug! Is this issue also present in the MesosContainerizer? If so, we should probably fix that in this review as well or at least have a ticket to block 0.19.0. src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/21966/#comment78518> Wasn't there a separate review already for this cloexec issue? src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/21966/#comment78515> Wasn't there an issue more accurately related to libev polling the prematurely closed file descriptor? It might be good to spell that out here for posterity! src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/21966/#comment78516> errno at this point is potentially tainted by the call to os::close src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/21966/#comment78517> Why not have two onAny's instead of the custom '_invoke' function? e.g. .onAny(bind(&os::close, fd)) .onAny(bind(&os::close, err.get()) - Ben Mahler On May 28, 2014, 8:26 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21966/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 8:26 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp b39c845 > > Diff: https://reviews.apache.org/r/21966/diff/ > > > Testing > ------- > > make check as well as Deimos (ECP) intergration tests > > > Thanks, > > Till Toenshoff > >
