> On May 28, 2014, 10:58 p.m., Ben Mahler wrote: > > src/slave/containerizer/external_containerizer.cpp, lines 1141-1144 > > <https://reviews.apache.org/r/21966/diff/2/?file=597812#file597812line1141> > > > > Wasn't there an issue more accurately related to libev polling the > > prematurely closed file descriptor? It might be good to spell that out here > > for posterity!
Due to the switch towards io::redirect, this comment is not needed anymore. For making sure other devs are aware of this danger, MESOS-1431 was created. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21966/#review44193 ----------------------------------------------------------- On May 29, 2014, 2:31 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21966/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 2:31 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1431 > https://issues.apache.org/jira/browse/MESOS-1431 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp b39c845 > > Diff: https://reviews.apache.org/r/21966/diff/ > > > Testing > ------- > > make check as well as Deimos (ECP) intergration tests > > > Thanks, > > Till Toenshoff > >
