----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22064/#review44405 -----------------------------------------------------------
src/slave/containerizer/linux_launcher.cpp <https://reviews.apache.org/r/22064/#comment78772> Having a cgroups::destroyTimedOut seems a bit strange to me, why is the library defining the timeout function? Would it be more intuitive for the library to be agnostic to timeout semantics? It would also make this code a bit easier to follow. - Ben Mahler On May 29, 2014, 10:27 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22064/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 10:27 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Use a timeout to discard cgroups::destroy. > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 36fa99758f72933f085baaae8c181348989ebc2e > src/slave/containerizer/isolators/cgroups/cpushare.cpp > b494a9236210245383e20fa9ab3dbac01e42f8dd > src/slave/containerizer/isolators/cgroups/mem.hpp > 6e792565ee3a61f99f244be68b378709577c63da > src/slave/containerizer/isolators/cgroups/mem.cpp > 6324dcd288975872c26685c713910d778def4e10 > src/slave/containerizer/linux_launcher.cpp > c17724b138de9d64856fb85db019e52043fbc7af > > Diff: https://reviews.apache.org/r/22064/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
