-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20817/#review44459
-----------------------------------------------------------
Bad patch!
Reviews applied: [20817]
Failed command: git apply --index 20817.patch
Error:
20817.patch:2576: trailing whitespace.
* Start the mesos-master binaries using the `--zk` flag, e.g.
`--zk=zk://host1:port1/path,host2:port2/path...'
error: patch failed: docs/powered-by-mesos.md:34
error: docs/powered-by-mesos.md: patch does not apply
error: patch failed: src/master/flags.hpp:206
error: src/master/flags.hpp: patch does not apply
error: patch failed: src/tests/scheduler_tests.cpp:1
error: src/tests/scheduler_tests.cpp: patch does not apply
- Mesos ReviewBot
On May 29, 2014, 10:26 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20817/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 10:26 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-473
> https://issues.apache.org/jira/browse/MESOS-473
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The Freezer tries to converge to the "FROZEN" state by repeatedly (every
> 100 ms) writing "FROZEN" to the freezer.state control file (up to a
> configurable timeout). It assumes there are two possible reasons why a
> process does not get frozen during an attempt:
>
> 1. It was in the middle of being forked and did not receive the signal;
> it will receive it at the next attempt.
>
> 2. It is in uninterruptable sleep ("D" state). Normally, this is from
> device I/O or paging and is shortlived, in which case it'll be frozen on
> retry. However, processes can get stuck in "D" state, either because of
> a device issue, incorrect OOM handling, or kernel bugs. Under this
> scenario the correct behavior is to fail after a timeout (defaults to 60
> seconds).
>
> Freezer functions have been namespaced under cgroups::freezer.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am
> 8f32a66c6ad593ff3bd508c7e687aaff22933324
> 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp
> 110cb49fe0a1306cfa8eeee1ffe7b542f75d69b7
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp
> 120946909cd19653ae5f71d401b5c9ea6d8228cd
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
> 72f3e70ccc189d0a7dd613ccaf79537d3587c49c
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/execenv.hpp
> 1dd6c90f35a5c060d2455fdf399b1fff44ba841b
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
> 3b60ff824bada441cd657e10ca01762085a6d099
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp
> 4fe3f22915cbc11df3f4424e3bd8acaf45509e19
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
> 1a6ce0b9a70c0334946e456696b814961e5b4018
> 3rdparty/libprocess/3rdparty/stout/tests/utils.hpp
> 070bc6e5375d85d6e055e2d526fcf026a3a3fc5c
> 3rdparty/libprocess/Makefile.am b687068b543947ab05482f5f34d982e017323007
> 3rdparty/libprocess/include/process/http.hpp
> 6358e331ae1256b19d52a6803875d2b64d75eb69
> 3rdparty/libprocess/include/process/io.hpp
> c77529034311ebb0347309ecaa175d2ef1d95208
> 3rdparty/libprocess/include/process/metrics/timer.hpp
> 01cb290d6b93e14f711b3bb5840c9910e54f2812
> 3rdparty/libprocess/include/process/owned.hpp
> ad6c734c9b8df23b6a331c5009a2c1219a25de6e
> 3rdparty/libprocess/include/process/system.hpp
> 48a02f0b0ebbf45331506e53a78a10f02c6fde44
> 3rdparty/libprocess/src/process.cpp
> 8501d2f08292d6790010ead58512376947ad53dc
> 3rdparty/libprocess/src/subprocess.cpp
> 9f8f37f5362aaa85f6b2f448d3f4d64a1c95f020
> 3rdparty/libprocess/src/tests/http_tests.cpp
> a1c3685c88d268c7ecdc2dad22608198dc0b295d
> 3rdparty/libprocess/src/tests/io_tests.cpp
> 05ea7bb389f670e190be9942b0782ee4cd2e2c08
> 3rdparty/libprocess/src/tests/metrics_tests.cpp
> 33539e45bab8f79afa773a325465016f01fd3b75
> 3rdparty/libprocess/src/tests/owned_tests.cpp
> 50025d98d3abd73f34b2d0052970776c37870ef8
> 3rdparty/libprocess/src/tests/system_tests.cpp
> a917790d8b1676195679d5ca908a4938cc898c7f
> bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65
> configure.ac 04095c4a97ce6d97da28c7d722d5eb5612d14e3c
> docs/configuration.md fb92cfaf185ee5daecff54038050bb5894ae92e4
> docs/getting-started.md 446396d043b8aa7dadc92fe7e17be69f3d471084
> docs/high-availability.md b2a62c41a19f6346c53afae468f3241687669313
> docs/mesos-developers-guide.md 036a6fd336c1173be73393e5ee62dba208378518
> docs/powered-by-mesos.md bc9233ddf29a08ce1075a8488272dae680a8b1e6
> include/mesos/mesos.proto 82388e1ed5ee36aaf7fc31d7a59aa0923ee9ab46
> src/Makefile.am ffde59be8683dd40cc5bc7cb88cd88c5bc91cf96
> src/authorizer/authorizer.hpp b0d1eae7e9e64a2ded6532de1f1bf5d2db70ecd7
> src/common/resources.cpp d39001bdabd14924c9ee3697ede81dd242768768
> src/launcher/fetcher.cpp c4425ebaf339a99b76e4e48628d2ac4761d2c408
> src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
> src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
> src/linux/routing/filter/arp.cpp c18aebb8eeae9ba537cbfcdb994db233d5e5b322
> src/linux/routing/filter/icmp.cpp 8e6f01344f4a7a2056a6051f22eb17b3b75b3b54
> src/linux/routing/filter/ip.hpp 8f46ee5aa42d73bc3e7d97f72802a918fbe9e4a1
> src/linux/routing/filter/ip.cpp 86dbf35a5e661d4a873b755cbaba4e06d001026d
> src/linux/routing/internal.hpp dca0dc55576932e1f68540388cbd0869079dace7
> src/linux/routing/link/link.cpp ebcd1190734b63b095d369850bea83810b9e55b5
> src/linux/routing/route.cpp 234027e90a85dc308046aa7c86fd7e49a8738b86
> src/master/flags.hpp e89022747fdda9dbe2124f4512931b7c1a32cfae
> src/master/http.cpp b565dc6c36a9e9e09b6b273e8d03e3d2c0c4438c
> src/master/master.hpp d4ef4bec7168179f2168e88d3727e50b0e2e68a1
> src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719
> src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573
> src/sasl/authenticator.hpp 365db5f040cdaec9d7691aa6984be3d929b8692b
> src/sched/sched.cpp be23e012fba99363b72b749b110f12ce3c902014
> src/slave/constants.hpp ace459071d7b1906fe8665878a60ae9edf7d0022
> src/slave/constants.cpp 51f65bb8b938690084460c0160fdc563657f3678
> src/slave/containerizer/external_containerizer.hpp
> 94dffbb75a3df7dbc9aaebbc5fd121967353750d
> src/slave/containerizer/external_containerizer.cpp
> b5d0c4cbc02957d099d83401423a77474d1d185e
> src/slave/containerizer/linux_launcher.hpp
> 60b401f26d369cafec46e03be61bd1df001c3544
> src/slave/containerizer/mesos_containerizer.cpp
> 14380240512d29b49c2e8f2831a9ef8ca102a024
> src/slave/flags.hpp 15e5b64fd24a9381074b4833a0403314e1f404bc
> src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62
> src/slave/slave.cpp c5c05132874b581829dfd191b8a553971fb8f3df
> src/state/protobuf.hpp 12f9bfb31a0a7c1fd22ad51c6bc6f6a028c41b4c
> src/tests/allocator_tests.cpp 79ea09c8d05aa3ac3c035ea3964858bff601e213
> src/tests/authentication_tests.cpp 5cf2da4602edbf7c168351d5f581aca10591d5d0
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
> src/tests/cluster.hpp f4cc9a62cd0ca86cd87987d963abd951a377ddd1
> src/tests/containerizer_tests.cpp 8ea7974ef74582afa9f670ccccb8139bad993cbc
> src/tests/environment.cpp 3e105084d5fcec30245f6d1a35a7dcc4c220b954
> src/tests/fault_tolerance_tests.cpp
> 4c6a5c4ecd42a5d0bb4b4d69ab2cd38f842edf7a
> src/tests/gc_tests.cpp df15746d1eea45c7da711144c51f74d0a82e0fca
> src/tests/isolator.hpp 89df4c4959c680354b002fa12e3a270a358087af
> src/tests/master_tests.cpp 7183cb7d567664a2f07b8d11980c8fbbec1711af
> src/tests/mesos.hpp 1b0f358cb008bc2cb81f5e72029d564921bcb379
> src/tests/mesos.cpp 3065ae30bceb8b258d071110c0360f701ff48b64
> src/tests/resource_offers_tests.cpp
> 653f72d3af41de21b05d913377cb4aa27f7fe823
> src/tests/routing_tests.cpp 0e8f61a569a908d310e5711af853dc8700efcac8
> src/tests/sasl_tests.cpp 59e1c95370879d4b006bfd80f16ce2a1f54a61df
> src/tests/scheduler_tests.cpp 721d1cf74d980649f43dfb9e8778036f1b7780a6
> src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b
> src/tests/slave_tests.cpp 80fe3cfd66c536fa02f5c42cf5fe7d8bdd4251ab
> src/tests/status_update_manager_tests.cpp
> c753921194a3ae449feff0b20dfc058b6e086528
> src/tests/utils.hpp 5c86fd47315ceb236c60e2baece9242da580587f
> src/usage/usage.hpp 5a76746d17cc70c2a35449f80cdd062ebdffe689
> src/usage/usage.cpp 29014d1763fa122096dae6065f68b28abade9401
> src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827
> src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
> src/webui/master/static/js/controllers.js
> 41a70a80442501a2bf7b217939dbe504662941d2
> src/zookeeper/zookeeper.cpp 9c0c038c7f7932688fb001c7ea88dc4088d633c9
> support/hooks/pre-commit f6910f852a51d64a3441f9c23e70cafc6f7de741
> support/mesos-style.py fd12be9ad1647e658bca45f181f9aa9da1a15084
> support/post-reviews.py 6814b0be5f53504b7a7094633bec718bb165d3e9
>
> Diff: https://reviews.apache.org/r/20817/diff/
>
>
> Testing
> -------
>
> make check # Linux
>
>
> Thanks,
>
> Ian Downes
>
>
