-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20817/
-----------------------------------------------------------
(Updated June 11, 2014, 3:21 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Terminate immediately on discard.
Bugs: MESOS-473
https://issues.apache.org/jira/browse/MESOS-473
Repository: mesos-git
Description
-------
The Freezer tries to converge to the "FROZEN" state by repeatedly (every
100 ms) writing "FROZEN" to the freezer.state control file (up to a
configurable timeout). It assumes there are two possible reasons why a
process does not get frozen during an attempt:
1. It was in the middle of being forked and did not receive the signal;
it will receive it at the next attempt.
2. It is in uninterruptable sleep ("D" state). Normally, this is from
device I/O or paging and is shortlived, in which case it'll be frozen on
retry. However, processes can get stuck in "D" state, either because of
a device issue, incorrect OOM handling, or kernel bugs. Under this
scenario the correct behavior is to fail after a timeout (defaults to 60
seconds).
Freezer functions have been namespaced under cgroups::freezer.
Diffs (updated)
-----
src/linux/cgroups.hpp 21d87a0783c2edd653d28fa89c59773200ae647e
src/linux/cgroups.cpp 142ac437d6d53b678ef284bda46444e1615ff0d1
src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
Diff: https://reviews.apache.org/r/20817/diff/
Testing
-------
make check # Linux
Thanks,
Ian Downes
