> On June 4, 2014, 9:19 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/gmock.hpp, line 51 > > <https://reviews.apache.org/r/21968/diff/15/?file=602048#file602048line51> > > > > This looks great but what about including the prefix EXPECT_? > > > > EXPECT_NO_FUTURE_MESSAGES(name, _, _); > > > > IMHO this will be easier to read. Action's like DROP_MESSAGE don't need > > the EXPECT_ prefix and we didn't originally add it to things like > > FUTURE_MESSAGE since they return a Future, but for "statements" like this I > > think the EXPECT_ prefix makes it more readable.
That's a good point! I agree. This should sound like an expectation. Thanks for suggestion! Ben! - Yifan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/#review44759 ----------------------------------------------------------- On June 4, 2014, 9:25 p.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21968/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 9:25 p.m.) > > > Review request for mesos, Adam B, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-878 > https://issues.apache.org/jira/browse/MESOS-878 > > > Repository: mesos-git > > > Description > ------- > > Added a sentence to check the slave's state in doReliableRegistration() to > make sure that the function returns when the slave's state is TERMINATING. > Also, to write the test, I need to make sure there's no additional > doReliableRegistration() calls, so I added NO_FUTURE_PROTOBUFS() and > NO_FUTURE_MESSAGES() to make sure there's no more SlaveReregisteredMessages. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gmock.hpp daba7e3 > src/slave/slave.cpp 3b10a4c > src/tests/mesos.hpp 9ece77a > src/tests/slave_tests.cpp 80fe3cf > > Diff: https://reviews.apache.org/r/21968/diff/ > > > Testing > ------- > > Slave_tests.cpp:TerminatingSlaveDoesNotReregister. > > > File Attachments > ---------------- > > Using DROP_PROTOBUF() > > https://reviews.apache.org/media/uploaded/files/2014/05/30/7c0e1b69-19c1-4868-865e-d47fbb739585__mesos.diff > > > Thanks, > > Yifan Gu > >
