-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21968/
-----------------------------------------------------------
(Updated June 4, 2014, 10:01 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, and Vinod Kone.
Changes
-------
Changed commit message.
Summary (updated)
-----------------
MESOS-878: Prevented slave from reregistering when TERMINATING.
Bugs: MESOS-878
https://issues.apache.org/jira/browse/MESOS-878
Repository: mesos-git
Description
-------
Added a sentence to check the slave's state in doReliableRegistration() to make
sure that the function returns when the slave's state is TERMINATING.
Also, to write the test, I need to make sure there's no additional
doReliableRegistration() calls, so I added EXPECT_NO_FUTURE_PROTOBUFS() and
EXPECT_NO_FUTURE_MESSAGES() to make sure there's no more
SlaveReregisteredMessages.
Diffs
-----
3rdparty/libprocess/include/process/gmock.hpp daba7e3
src/slave/slave.cpp 3b10a4c
src/tests/mesos.hpp 9ece77a
src/tests/slave_tests.cpp 80fe3cf
Diff: https://reviews.apache.org/r/21968/diff/
Testing
-------
Slave_tests.cpp:TerminatingSlaveDoesNotReregister.
File Attachments
----------------
Using DROP_PROTOBUF()
https://reviews.apache.org/media/uploaded/files/2014/05/30/7c0e1b69-19c1-4868-865e-d47fbb739585__mesos.diff
Thanks,
Yifan Gu
