----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review44952 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment79535> Please remove these TODOs not that you've addressed them. src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment79537> Could the framework be removed while the update is happening? src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment79538> ditto src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment79536> So the task is lost but what happens then; should we consider destroying the container? - Ian Downes On June 6, 2014, 11:48 a.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22313/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 11:48 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-886 > https://issues.apache.org/jira/browse/MESOS-886 > > > Repository: mesos-git > > > Description > ------- > > Added __runTask() to wait for the completion of containerizer->update() and > check the result before sending RunTaskMessage. > > > Diffs > ----- > > src/slave/slave.hpp 34687e5 > src/slave/slave.cpp 643c088 > src/tests/slave_tests.cpp 2c8f183 > > Diff: https://reviews.apache.org/r/22313/diff/ > > > Testing > ------- > > SlaveTest, CancelTaskIfContainerizerFails > > Which tests that if the containerizer->update() return a Failure, the task > won't be launched and the scheduler will get TASK_LOST. > > make check > > > Thanks, > > Yifan Gu > >
