> On June 6, 2014, 7 p.m., Ian Downes wrote: > > src/slave/slave.cpp, line 1211 > > <https://reviews.apache.org/r/22313/diff/2/?file=604829#file604829line1211> > > > > Could the framework be removed while the update is happening?
Good catch! Thanks! I think I can simply check the NULL pointer here instead of putting the task into the pending map of the framework. Because even though the framework won't get shutdown when it has a pending task. The executor will have a chance to be shutdown and cause a NULL pointer. Please point me out if I am making some wrong assumption. Thanks > On June 6, 2014, 7 p.m., Ian Downes wrote: > > src/slave/slave.cpp, line 1176 > > <https://reviews.apache.org/r/22313/diff/2/?file=604829#file604829line1176> > > > > Please remove these TODOs not that you've addressed them. Will do. > On June 6, 2014, 7 p.m., Ian Downes wrote: > > src/slave/slave.cpp, line 1217 > > <https://reviews.apache.org/r/22313/diff/2/?file=604829#file604829line1217> > > > > So the task is lost but what happens then; should we consider > > destroying the container? Good point! But I think since the executor can be reused later. Maybe we can let it continue to live here for a while? Cuz otherwise when the executor gets removed later, the container will be destroyed. IMO - Yifan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review44952 ----------------------------------------------------------- On June 6, 2014, 6:48 p.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22313/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 6:48 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-886 > https://issues.apache.org/jira/browse/MESOS-886 > > > Repository: mesos-git > > > Description > ------- > > Added __runTask() to wait for the completion of containerizer->update() and > check the result before sending RunTaskMessage. > > > Diffs > ----- > > src/slave/slave.hpp 34687e5 > src/slave/slave.cpp 643c088 > src/tests/slave_tests.cpp 2c8f183 > > Diff: https://reviews.apache.org/r/22313/diff/ > > > Testing > ------- > > SlaveTest, CancelTaskIfContainerizerFails > > Which tests that if the containerizer->update() return a Failure, the task > won't be launched and the scheduler will get TASK_LOST. > > make check > > > Thanks, > > Yifan Gu > >
