----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22441/#review45407 -----------------------------------------------------------
src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/22441/#comment80251> this is the default. why did you need to set it here? src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/22441/#comment80257> Can you add a comment on why you are doing a settle here? I'm still a bit unclear after reading your description. - Vinod Kone On June 10, 2014, 8:40 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22441/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 8:40 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-1437 > https://issues.apache.org/jira/browse/MESOS-1437 > > > Repository: mesos-git > > > Description > ------- > > Occasionally the task would fail due to unknown container before we started > the recover. Moving the pause earlier to ensure we are ready for the failure > before we see it. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b > > Diff: https://reviews.apache.org/r/22441/diff/ > > > Testing > ------- > > make check x 1500 > > > Thanks, > > Dominic Hamon > >
