> On June 12, 2014, 6:05 p.m., Ian Downes wrote: > > src/tests/slave_recovery_tests.cpp, line 3053 > > <https://reviews.apache.org/r/22441/diff/2/?file=607620#file607620line3053> > > > > I think we also need to expect the wait() and do nothing for that as > > well. See the ticket for details.
+1 - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22441/#review45515 ----------------------------------------------------------- On June 11, 2014, 9:01 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22441/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 9:01 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-1437 > https://issues.apache.org/jira/browse/MESOS-1437 > > > Repository: mesos-git > > > Description > ------- > > Occasionally the task would fail due to unknown container before we started > the recover. Moving the pause earlier to ensure we are ready for the failure > before we see it. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b > > Diff: https://reviews.apache.org/r/22441/diff/ > > > Testing > ------- > > make check x 1500 > > > Thanks, > > Dominic Hamon > >
