----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review45525 -----------------------------------------------------------
Could you add a test that ensures the unregister message is sent? You can do this via FUTURE_MESSAGE. The test could also ensure that the master correctly removes the slave from the registrar. - Ben Mahler On June 10, 2014, 10:13 a.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22367/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 10:13 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-544 > https://issues.apache.org/jira/browse/MESOS-544 > > > Repository: mesos-git > > > Description > ------- > > Second phase: Mesos-slave support for "node drain" > * create a method that sends UnregisterRequestMessage to the master > * dispatch that method in the signal handler, which executes when SIGUSR1 is > issued > > ** This review relies on https://reviews.apache.org/r/21379/ > > > Diffs > ----- > > src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62 > src/slave/slave.cpp 643c0882a4bab1b612b3fb6fd1004e09edf5f368 > > Diff: https://reviews.apache.org/r/22367/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
