----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22367/#review46951 -----------------------------------------------------------
Patch looks great! Reviews applied: [22367] All tests passed. - Mesos ReviewBot On June 28, 2014, 5:22 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22367/ > ----------------------------------------------------------- > > (Updated June 28, 2014, 5:22 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-544 > https://issues.apache.org/jira/browse/MESOS-544 > > > Repository: mesos-git > > > Description > ------- > > Second phase: Mesos-slave support for "node drain" > * create a method that sends UnregisterRequestMessage to the master > * dispatch that method in the signal handler, which executes when SIGUSR1 is > issued > > ** This review relies on https://reviews.apache.org/r/21379/ > > > Diffs > ----- > > src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857 > src/master/master.cpp 21b07c7f1f445beac29a7781cf441dd79b1b7fb5 > src/slave/slave.cpp 24eb8fd9f1e168e1f0917a8c14bf82f42d2e43ce > > Diff: https://reviews.apache.org/r/22367/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
