----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45779 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/22316/#comment80757> const std::string& ? src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80758> is this simpler? metrics.frameworks.get(principal.get()).get()->messages_received++; src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80759> ditto above re not creating a copy. - Dominic Hamon On June 13, 2014, 3:48 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22316/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 3:48 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1339 > https://issues.apache.org/jira/browse/MESOS-1339 > > > Repository: mesos-git > > > Description > ------- > > - Multiple frameworks use the same principal use the same counter. > > > Diffs > ----- > > src/Makefile.am c91b438c3401ff815116d6faab4f0a34bc0fe3fd > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22316/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
