----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45428 -----------------------------------------------------------
>From the review meeting with Vinod and BenM. src/master/master.hpp <https://reviews.apache.org/r/22316/#comment80288> delete 'that' src/master/master.hpp <https://reviews.apache.org/r/22316/#comment80292> Create a struct to group theses and have a comment about how they are exported differently Also no need to use Owned src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80301> Instead of checking UPID -> principal mapping, should check if the counter still exists. If yes, increment it. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80293> Explain why checking two sources for the principal. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80295> Use Option<string> principal. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80294> If framework principal is not specified, we don't export its message counters. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80296> Expand on this. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment80297> (i.e. explain 'failover') - Jiang Yan Xu On June 11, 2014, 1:49 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22316/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 1:49 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1339 > https://issues.apache.org/jira/browse/MESOS-1339 > > > Repository: mesos-git > > > Description > ------- > > - Multiple frameworks use the same principal use the same counter. > > > Diffs > ----- > > src/Makefile.am c91b438c3401ff815116d6faab4f0a34bc0fe3fd > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > src/tests/rate_limiting_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22316/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
