> On June 13, 2014, 5:28 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 688-692 > > <https://reviews.apache.org/r/22425/diff/3/?file=609705#file609705line688> > > > > It would be nice to allow operators to explicitly specify default QPS > > for principals that are not specified in the limits. > > > > We could do this pretty easily by adding an optional 'default_qps' > > field here: > > > > // QPS for unspecified principals, if left unset, then no rate limit > > will be enforced. > > optional default_qps = 2; > > Jiang Yan Xu wrote: > Should all frameworks with unspecified principals be throttled together? > i.e. should they each get default_qps or they should collectively get > default_qps? > > I think the name 'default_qps' intuitively suggests the former but from > the operator's POV, it's more useful if it's the latter because this > effectively limits the unexpected traffic. > > And this can probably be in its own patch with the Master logic together. > > Vinod Kone wrote: > The latter sounds good. Just make sure you clearly comment that in the > proto. > > Also, this patch is straightforward. So, just add the "default_qps" in > this patch instead of splitting the protobuf format across separate reviews.
To summarize the offline chat with Vinod and BenM: 1) Name this optional "default" variable "aggregate_default_qps": all the frameworks not specified in RateLimits config are throttled together using on RateLimiter if this variable is set. 2) For frameworks you want to grant unlimited bandwidth explicitly, set the 'principal' but do not set the 'qps' (will make it optional) - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22425/#review45681 ----------------------------------------------------------- On June 13, 2014, 4 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22425/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 4 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Bugs: MESOS-1443 > https://issues.apache.org/jira/browse/MESOS-1443 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 8c6933db495ef0bb3c14301d8077d31ecb123f59 > src/master/flags.hpp 780e219e81e3df57da197784f67deab2b0de4382 > src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 > src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 > > Diff: https://reviews.apache.org/r/22425/diff/ > > > Testing > ------- > > make check (tested along with https://reviews.apache.org/r/22427) > > > Thanks, > > Jiang Yan Xu > >
